On Mon, 2010-03-15 at 12:26 +0100, Quadros Roger (Nokia-D/Helsinki) wrote: > Hi, > > Valkeinen Tomi (Nokia-D/Helsinki) wrote: > > On Fri, 2010-03-12 at 16:27 +0100, Quadros Roger (Nokia-D/Helsinki) > > wrote: > >> From: Roger Quadros <roger.quadros@xxxxxxxxx> > >> > >> This patch enables the use of vdds_sdi regulator in SDI subsystem. > >> We can disable the vdds_sdi voltage when not in use to save > >> power. > >> > >> Signed-off-by: Roger Quadros <roger.quadros@xxxxxxxxx> > >> --- > >> drivers/video/omap2/dss/sdi.c | 23 +++++++++++++++++++++-- > >> 1 files changed, 21 insertions(+), 2 deletions(-) > >> <snip> > > And why do you test for omap34xx? > > > I just assumed that, so i guess that was wrong. Will check the TRM and fix it. Well, SDI is only for omap34xx. But why do you test it inside sdi.c, and only for the regulator? I don't think SDI will work any better on OMAP3630 (which doesn't have the SDI block), even if you don't use the regulators ;). So I think it's safe to assume inside sdi.c that we are running on a device with SDI HW block. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
