On Tue, 16 Feb 2010 18:19:21 +0000 (GMT) James Simmons <jsimmons@xxxxxxxxxxxxx> wrote: > > A simple patch to allow radeonfb to compile if the backlight option is > set. > > diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c > index 6c37e8e..2c01726 100644 > --- a/drivers/video/aty/radeon_base.c > +++ b/drivers/video/aty/radeon_base.c > @@ -276,7 +276,7 @@ static int nomtrr = 0; > #endif > static int force_sleep; > static int ignore_devlist; > -#ifdef CONFIG_PMAC_BACKLIGHT > +#ifdef CONFIG_FB_RADEON_BACKLIGHT > static int backlight = 1; > #else > static int backlight = 0; Changelog is very poor. It doesn't tell us what the error was, nor how the patch fixes it. I attempted to reverse-engineer the patch but gave up. radeonfb_bl_init() is omitted from the link if CONFIG_FB_RADEON_BACKLIGHT=n. And this code: if (backlight) radeonfb_bl_init(rinfo); will emit a call to radeonfb_bl_init() regardless of the value of `backlight', so as far as I can tell, there will be a linkage error with CONFIG_FB_RADEON_BACKLIGHT=n both before and after your patch. So. Please resend, with a proper description. And a Signed-off-by: line. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
