Hi Uwe, On Wed, Feb 10, 2010 at 08:53:15AM +0100, Uwe Kleine-König wrote: > On Wed, Feb 10, 2010 at 09:25:19AM +0200, Baruch Siach wrote: > > @@ -233,6 +242,9 @@ int __init mx25_clocks_init(void) > > __raw_writel((0xf << 16) | (3 << 26), CRM_BASE + CCM_CGCR1); > > __raw_writel((1 << 5), CRM_BASE + CCM_CGCR2); > > > > + /* Clock source for lcdc is upll */ > > + __raw_writel(__raw_readl(CRM_BASE+0x64) | (1 << 7), CRM_BASE + 0x64); > > + > 0x64? Please define a register name for that constant. I just followed the precedence set in the get_rate_per() routine above. Defining a register name is obviously better. > Ditto for 7. See arch/arm/mach-mx3/clock.c:mx31_clocks_init() and arch/arm/mach-mx3/clock-imx35.c:mx35_clocks_init(). This is probably a matter for a separate cleanup patch. > Note I didn't look in the hardware manual, but I wonder if that should > better go in the enable routine for lcdc? OK. I'll do it there. baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html