> From: Julia Lawall <julia@xxxxxxx> > > Test the value that was just allocated rather than the previously tested one. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @r@ > expression *x; > expression e; > identifier l; > @@ > > if (x == NULL || ...) { > ... when forall > return ...; } > ... when != goto l; > when != x = e > when != &x > *x == NULL > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> Acked-by: James Simmons <jsimmons@xxxxxxxxxxxxx> > --- > drivers/video/mbx/mbxfb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/mbx/mbxfb.c b/drivers/video/mbx/mbxfb.c > index afea9ab..7140405 100644 > --- a/drivers/video/mbx/mbxfb.c > +++ b/drivers/video/mbx/mbxfb.c > @@ -950,7 +950,7 @@ static int __devinit mbxfb_probe(struct platform_device *dev) > > mfbi->fb_virt_addr = ioremap_nocache(mfbi->fb_phys_addr, > res_size(mfbi->fb_req)); > - if (!mfbi->reg_virt_addr) { > + if (!mfbi->fb_virt_addr) { > dev_err(&dev->dev, "failed to ioremap frame buffer\n"); > ret = -EINVAL; > goto err4; > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
