2009/11/20 Eric Miao <eric.y.miao@xxxxxxxxx>: >> + int err = 0; >> + if (on) { >> + if (spi_gpio_reset != -1) { >> + err = gpio_request(spi_gpio_reset, "TPO_LCD_SPI_RESET"); >> + if (err) { >> + printk(KERN_ERR "failed to request GPIO for TPO LCD RESET\n"); >> + return err; >> + } >> + gpio_direction_output(spi_gpio_reset, 0); >> + msleep(100); > > This is really a loooong delay, there any specific reason for such a long > delay, I'm seeing this to slow down the boot up significantly? > > Otherwise looks OK to me, and I prefer the defconfig file change to > be a separate patch please. > Actually, This is just an example for other real products. There is no such spi_reset pin on Aspenite , so machine info set it spi_gpio_reset == -1. Or do you think we should delete these lines? -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html