On Sat, Mar 08, 2025 at 03:20:34PM +0800, Zorro Lang wrote: > On Fri, Mar 07, 2025 at 01:35:02PM +0530, Nirjhar Roy (IBM) wrote: > > > > On 3/7/25 03:00, Dave Chinner wrote: > > > On Thu, Mar 06, 2025 at 08:17:41AM +0000, Nirjhar Roy (IBM) wrote: > > > > Silently executing scripts during sourcing common/rc doesn't look good > > > > and also causes unnecessary script execution. Decouple init_rc() call > > > > and call init_rc() explicitly where required. > > > > > > > > Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@xxxxxxxxx> > > > FWIW, I've just done somethign similar for check-parallel. I need to > > > decouple common/config from common/rc and not run any code from > > > either common/config or common/rc. > > > > > > I've included the patch below (it won't apply because there's all > > > sorts of refactoring for test list and config-section parsing in the > > > series before it), but it should give you an idea of how I think we > > > should be separating one-off initialisation environment varaibles, > > > common code inclusion and the repeated initialisation of section > > > specific parameters.... > > Thank you so much. I can a look at this. > > > > > > ..... > > > > diff --git a/soak b/soak > > > > index d5c4229a..5734d854 100755 > > > > --- a/soak > > > > +++ b/soak > > > > @@ -5,6 +5,7 @@ > > > > # get standard environment, filters and checks > > > > . ./common/rc > > > > +# ToDo: Do we need an init_rc() here? How is soak used? > > > > . ./common/filter > > > I've also go a patch series that removes all these old 2000-era SGI > > > QE scripts that have not been used by anyone for the last 15 > > > years. I did that to get rid of the technical debt that these > > > scripts have gathered over years of neglect. They aren't used, we > > > shouldn't even attempt to maintain them anymore. > > > > Okay. What do you mean by SGI QE script (sorry, not familiar with this)? Do > > you mean some kind of CI/automation-test script? > > SGI is Silicon Graphics International Corp. : > https://en.wikipedia.org/wiki/Silicon_Graphics_International > > xfstests was created to test xfs on IRIX (https://en.wikipedia.org/wiki/IRIX) > of SGI. Dave Chinner worked in SGI company long time ago, so he's the expert > of all these things, and knows lots of past details :) Hi Nirjhar, I've merged Dave's "[PATCH 0/5] fstests: remove old SGI QE scripts" into patches-in-queue branch. You can base on that to write your V2, to avoid dealing with the "soak" file. Thanks, Zorro > > Thanks, > Zorro > > > > > --NR > > > > > > > > -Dave. > > > > > -- > > Nirjhar Roy > > Linux Kernel Developer > > IBM, Bangalore > > > >
