Re: [PATCH] ext4: remove unnecessary checks for __GFP_NOFAIL allocation.

[Baokun Li <libaokun1@xxxxxxxxxx>]

On 2025/2/28 16:11, Julian Sun wrote:
> The __GFP_NOFAIL flag ensures that allocation will not fail.
> So remove the unnecessary checks.
Actually, even with __GFP_NOFAIL set, kcalloc() can still return NULL,
such as when the input parameters overflow.


Baokun
> Signed-off-by: Julian Sun <sunjunchao2870@xxxxxxxxx>
> ---
>   fs/ext4/extents.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index a07a98a4b97a..95debd5d6506 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -2940,10 +2940,6 @@ int ext4_ext_remove_space(struct inode *inode, ext4_lblk_t start,
>   	} else {
>   		path = kcalloc(depth + 1, sizeof(struct ext4_ext_path),
>   			       GFP_NOFS | __GFP_NOFAIL);
> -		if (path == NULL) {
> -			ext4_journal_stop(handle);
> -			return -ENOMEM;
> -		}
>   		path[0].p_maxdepth = path[0].p_depth = depth;
>   		path[0].p_hdr = ext_inode_hdr(inode);
>   		i = 0;