Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx> writes: > Currently, outside error paths, we auto commit the super block after 1 > hour has passed and 16MB worth of updates have been written since last > commit. This is a policy decision so make this tunable while keeping the > defaults same. This is useful if user wants to tweak the superblock > update behavior or for debugging the codepath by allowing to trigger it > more frequently. > > We can now tweak the super block update using sb_update_sec and > sb_update_kb files in /sys/fs/ext4/<dev>/ Agree that this could be useful as a tunable knob for various reasons rather than being a hardcoded value within kernel. The patch also looks good to me. Please feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>
