On 2025/2/6 17:46, Jan Kara wrote: > Journal emptiness is not determined by sb->s_sequence == 0 but rather by > sb->s_start == 0 (which is set a few lines above). Furthermore 0 is a > valid transaction ID so the check can spuriously trigger. Remove the > invalid WARN_ON. > > CC: stable@xxxxxxxxxxxxxxx > Signed-off-by: Jan Kara <jack@xxxxxxx> This is indeed subtle, it looks good to me. Reviewed-by: Zhang Yi <yi.zhang@xxxxxxxxxx> > --- > fs/jbd2/journal.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index 7e49d912b091..354c9f691df3 100644 > --- a/fs/jbd2/journal.c > +++ b/fs/jbd2/journal.c > @@ -1879,7 +1879,6 @@ int jbd2_journal_update_sb_log_tail(journal_t *journal, tid_t tail_tid, > > /* Log is no longer empty */ > write_lock(&journal->j_state_lock); > - WARN_ON(!sb->s_sequence); > journal->j_flags &= ~JBD2_FLUSHED; > write_unlock(&journal->j_state_lock); >
