On Mon, Feb 03, 2025 at 07:40:29AM +0100, Christoph Hellwig wrote: > On Sun, Feb 02, 2025 at 09:31:01PM +0800, Zorro Lang wrote: > > generic/730 is missed: > > > > /var/lib/xfstests/tests/generic/370: line 31: _supported_fs: command not found > > > > Anyway, I'll help to change g/370 when I merge this patch. > > generic/730 didn't exist when I submitted this series, you applied > it in the same batch of patches. Yeah, sorry it's from another patch which was in the same fstests release with yours :) I've fix this "conflict" and pushed, please refer to the latest for-next branch. Thanks, Zorro > > But it really should not skip xfs to start with. Either the test > is correct and XFS should fail it (and get fixed) or the test is > incorrect and it should not be added. I suspect it is the former > and I'll look into fixing it. > > As added in the comments in this series we should never add a > _exclude_fs without a very good reason and comment explaining it. >
