On Tue, Jan 28, 2025 at 11:14:42AM -0800, Darrick J. Wong wrote: > I went looking in common/dump and I noticed the lack of an explicit > setup routine. Instead, variables and _require calls are done when > sourcing the file. Curiously there's no check for FSTYP==xfs, which I > guess is reasonable for sourced stuff, but I think that should all get > pulled up into _init_dump() or something. > > The other thing I noticed is that sourcing common/dump deletes > $seqres.full, which seems like a real bug. Yeah, dump testing is at least as messy as xfsdump itself :) Btw, did someone every spend some time analyzing why xfs/059 xfs/060 fail relatively frequently when using RT devices? This is one of the thing on my TODO list when I find a little more time..
