Re: [RFC PATCH v2 1/8] block: introduce BLK_FEAT_WRITE_ZEROES_UNMAP to queue limits features

To: Zhang Yi <yi.zhang@xxxxxxxxxxxxxxx>
Subject: Re: [RFC PATCH v2 1/8] block: introduce BLK_FEAT_WRITE_ZEROES_UNMAP to queue limits features
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 28 Jan 2025 07:44:23 +0100
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, hch@xxxxxx, tytso@xxxxxxx, djwong@xxxxxxxxxx, yi.zhang@xxxxxxxxxx, chengzhihao1@xxxxxxxxxx, yukuai3@xxxxxxxxxx, yangerkun@xxxxxxxxxx
In-reply-to: <20250115114637.2705887-2-yi.zhang@huaweicloud.com>
References: <20250115114637.2705887-1-yi.zhang@huaweicloud.com> <20250115114637.2705887-2-yi.zhang@huaweicloud.com>
User-agent: Mutt/1.5.17 (2007-11-01)

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [RFC PATCH v2 0/8] fallocate: introduce FALLOC_FL_WRITE_ZEROES flag
  - From: Zhang Yi
- [RFC PATCH v2 1/8] block: introduce BLK_FEAT_WRITE_ZEROES_UNMAP to queue limits features
  - From: Zhang Yi