On 10/21/24 4:24 AM, Luis Henriques wrote: > On Fri, Oct 18 2024, Eric Sandeen wrote: > >> On 6/11/24 9:27 AM, Luis Henriques (SUSE) wrote: >>> Hi! >>> >>> I'm sending a fix to e2fsck that forces the filesystem checks to happen >>> when the orphan file is present in the filesystem. This patch resulted from >>> a bug reported in openSUSE Tumbleweed[1] where e2fsck doesn't clean-up this >>> file and later the filesystem fails to be mounted read-only (because it >>> still requires recovery). >> >> Looks like Fedora is hitting this bug now: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=2318710 >> >> (unclear why fedora upgrade is leaving an unclean root fs on reboot, but >> that's a separate issue.) >> >> With this patch in place, bare e2fsck asks for confirmation, not sure if that's >> expected. But with "yes" answers, the filesystem is cleaned properly and >> mounts just fine. >> >> Also - shouldn't we go ahead and deal with the orphan inode file even on a >> readonly mount, as long as the bdev itself is not readonly? > > Since that would be a filesystem-level change, my opinion is that we > should not do that in a read-only mount. But that's just my opinion and > maybe there are other similar cases (I didn't check) where changes are > written on read-only mounts. Well, we do the whole log replay on readonly mounts, as long as the device itself is not RO. But I guess I don't know if we fully process orphan inodes during an RO replay. *shrug* Anyway, thank you for this patch, it's in Fedora now, would be great to get it upstream. -Eric
