On Mon 30-09-24 08:59:40, Ye Bin wrote:
> From: Ye Bin <yebin10@xxxxxxxxxx>
>
> Factor out jbd2_do_replay() no funtional change.
>
> Signed-off-by: Ye Bin <yebin10@xxxxxxxxxx>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Just one style nit below:
> + lock_buffer(nbh);
> + memcpy(nbh->b_data, obh->b_data, journal->j_blocksize);
> + if (flags & JBD2_FLAG_ESCAPE) {
> + *((__be32 *)nbh->b_data) =
> + cpu_to_be32(JBD2_MAGIC_NUMBER);
^^ this needs one more indent
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
