>>>> Release inode_bitmap_bh from ext4_read_inode_bitmap in >>>> ext4_mark_inode_used to avoid buffer_head leak. >>>> By the way, remove unneeded goto for invalid ino when inode_bitmap_bh >>>> is NULL. >>> >>> 1. I suggest to split such changes into separate update steps. >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc3#n81 >> It's acceptable to me, but I'm not sure if it worth separate patches >> to others. I will do separate in next version if no person is against >> this. > > No, that suggestion is stupid. Please reconsider such a view a bit more. > There's no reason to generate even more > patches for a three line fix, it's very obvious that you're fixing a > missing resource release and rearranging the first error out > accordingly. You would probably like to distinguish the severity for two changes, wouldn't you? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc3#n168 Under which circumstances can you accept the separation of development concerns better? Regards, Markus
