Re: [PATCH v5.10] ext4: fix error code saved on super block during file system abort

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 23, 2024 at 12:17:19PM +0530, Ajay Kaher wrote:
> From: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx>
> 
> [ Upstream commit 124e7c61deb27d758df5ec0521c36cf08d417f7a ]
> 
> ext4_abort will eventually call ext4_errno_to_code, which translates the
> errno to an EXT4_ERR specific error.  This means that ext4_abort expects
> an errno.  By using EXT4_ERR_ here, it gets misinterpreted (as an errno),
> and ends up saving EXT4_ERR_EBUSY on the superblock during an abort,
> which makes no sense.
> 
> ESHUTDOWN will get properly translated to EXT4_ERR_SHUTDOWN, so use that
> instead.
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/20211026173302.84000-1-krisman@xxxxxxxxxxxxx
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
> Signed-off-by: Ajay Kaher <ajay.kaher@xxxxxxxxxxxx>
> ---

Both now queued up, thanks.

greg k-h




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux