On July 21, 2024 9:19:24 PM PDT, "Darrick J. Wong" <djwong@xxxxxxxxxx> wrote: >On Sun, Jul 21, 2024 at 09:10:59PM +0000, Artem S. Tashkinov wrote: >> Hello, >> >> There are now two bug reports containing very similar if not exactly the >> same backtraces. >> >> https://bugzilla.kernel.org/show_bug.cgi?id=219072 >> https://bugzilla.kernel.org/show_bug.cgi?id=219078 >> >> Theodore, please take a look. > >[adding everyone involved in 744a56389f739 ("ext4: replace deprecated >strncpy with alternatives") to cc] > >Is strscpy_pad appropriate if the @src parameter itself is a fixed >length char[16] which isn't null terminated when the label itself is 16 >chars long? Nope; it needed memtostr_pad(). I sent the fix back at the end of May, but it only just recently landed: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be27cd64461c45a6088a91a04eba5cd44e1767ef -Kees -- Kees Cook
