Of course that probably doesn't help you, because then the call would be vmf_insert_page_pmd() rather than a raw pfn, but as you point out there might be some common code we could share. > > As most of the rest look very similar to what pfn injections would need.. > and in the PoC of ours we're using vmf_insert_pfn_pmd/pud(). Do you have the PoC posted anywhere so I can get an understanding of how this might be used? > That also reminds me on whether it'll be easier to implement the new dax > support for page struct on top of vmf_insert_pfn_pmd/pud, rather than > removing the 1st then adding the new one. Maybe it'll reduce code churns, > and would that also make reviews easier? Yeah, that's a good observation. I think it was just a quirk of how I was developing this and also not caring about the PFN case so I'll see what that looks like. > It's also possible I missed something important so the old function must be > removed. > > Thanks,
