tl;dr for those who have been following along: There are several changes in this version. The conversion of ctime to be a ktime_t value has been dropped, and we now use an unused bit in the nsec field as the QUERIED flag (like the earlier patchset did). The floor value is now tracked as a monotonic clock value, and is converted to a realtime value on an as-needed basis. This eliminates the problem of trying to detect when the realtime clock jumps backward. Longer patch description for those just joining in: At LSF/MM this year, we had a discussion about the inode change attribute. At the time I mentioned that I thought I could salvage the multigrain timestamp work that had to be reverted last year [1]. That version had to be reverted because it was possible for a file to get a coarse grained timestamp that appeared to be earlier than another file that had recently gotten a fine-grained stamp. This version corrects the problem by establishing a per-time_namespace ctime_floor value that should prevent this from occurring. In the above situation, the two files might end up with the same timestamp value, but they won't appear to have been modified in the wrong order. That problem was discovered by the test-stat-time gnulib test. Note that that test still fails on multigrain timestamps, but that's because its method of determining the minimum delay that will show a timestamp change will no longer work with multigrain timestamps. I have a patch to change the testcase to use a different method that is in the process of being merged. The testing I've done seems to show performance parity with multigrain timestamps enabled vs. disabled, but it's hard to rule this out regressing some workload. This set is based on top of Christian's vfs.misc branch (which has the earlier change to track inode timestamps as discrete integers). If there are no major objections, I'd like to let this soak in linux-next for a bit to see if any problems shake out. [1]: https://lore.kernel.org/linux-fsdevel/20230807-mgctime-v7-0-d1dec143a704@xxxxxxxxxx/ To: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx> To: Christian Brauner <brauner@xxxxxxxxxx> To: Jan Kara <jack@xxxxxxx> To: Steven Rostedt <rostedt@xxxxxxxxxxx> To: Masami Hiramatsu <mhiramat@xxxxxxxxxx> To: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> To: Chandan Babu R <chandan.babu@xxxxxxxxxx> To: Darrick J. Wong <djwong@xxxxxxxxxx> To: Theodore Ts'o <tytso@xxxxxxx> To: Andreas Dilger <adilger.kernel@xxxxxxxxx> To: Chris Mason <clm@xxxxxx> To: Josef Bacik <josef@xxxxxxxxxxxxxx> To: David Sterba <dsterba@xxxxxxxx> To: Hugh Dickins <hughd@xxxxxxxxxx> To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> To: Jonathan Corbet <corbet@xxxxxxx> Cc: Dave Chinner <david@xxxxxxxxxxxxx> Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx> Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx> Cc: kernel-team@xxxxxx Cc: linux-fsdevel@xxxxxxxxxxxxxxx Cc: linux-kernel@xxxxxxxxxxxxxxx Cc: linux-trace-kernel@xxxxxxxxxxxxxxx Cc: linux-xfs@xxxxxxxxxxxxxxx Cc: linux-ext4@xxxxxxxxxxxxxxx Cc: linux-btrfs@xxxxxxxxxxxxxxx Cc: linux-mm@xxxxxxxxx Cc: linux-nfs@xxxxxxxxxxxxxxx Cc: linux-doc@xxxxxxxxxxxxxxx Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> Changes in v3: - Drop the conversion of i_ctime fields to ktime_t, and use an unused bit of the i_ctime_nsec field as QUERIED flag. - Better tracepoints for tracking floor and ctime updates - Reworked percpu counters to be more useful - Track floor as monotonic value, which eliminates clock-jump problem Changes in v2: - Added Documentation file - Link to v1: https://lore.kernel.org/r/20240626-mgtime-v1-0-a189352d0f8f@xxxxxxxxxx --- Jeff Layton (9): fs: add infrastructure for multigrain timestamps fs: tracepoints around multigrain timestamp events fs: add percpu counters to count fine vs. coarse timestamps fs: have setattr_copy handle multigrain timestamps appropriately Documentation: add a new file documenting multigrain timestamps xfs: switch to multigrain timestamps ext4: switch to multigrain timestamps btrfs: convert to multigrain timestamps tmpfs: add support for multigrain timestamps Documentation/filesystems/multigrain-ts.rst | 120 +++++++++++++++ fs/attr.c | 52 ++++++- fs/btrfs/file.c | 25 +--- fs/btrfs/super.c | 3 +- fs/ext4/super.c | 2 +- fs/inode.c | 224 ++++++++++++++++++++++++---- fs/stat.c | 39 ++++- fs/xfs/libxfs/xfs_trans_inode.c | 6 +- fs/xfs/xfs_iops.c | 10 +- fs/xfs/xfs_super.c | 2 +- include/linux/fs.h | 34 ++++- include/trace/events/timestamp.h | 109 ++++++++++++++ mm/shmem.c | 2 +- 13 files changed, 550 insertions(+), 78 deletions(-) --- base-commit: cc8223373449ecbd4c18932820714235db6006c4 change-id: 20240626-mgtime-5cd80b18d810 Best regards, -- Jeff Layton <jlayton@xxxxxxxxxx>
