On Thu, Jun 20, 2024 at 11:19:30AM +0800, wangjianjian (C) wrote: > On 2024/6/20 7:36, Theodore Ts'o wrote: > > bd2: fix descriptor block size handling errors with journal_csum > > in 2016 --- a full eight years ago. So it's probably not worth adding > the comment at this point. > > Thanks for detailed information, but is it better to put it in document in > case any other one confuse about this when read code. The comment would probably make things more confusing, since there's a much larger context involving the fact that csum_v2 is an obsolete format that in practice is never used. Sure, we could make the comment even more verbose, but perhaps it would be better to simply completely remove csum_v1 and csum_v2 from the code. That will probably make the code even more simpler to read. Cheers, - Ted
