On 2024/6/25 1:01, Jan Kara wrote: > In jbd2_journal_init_common() we set batch size of a shrinker shrinking > checkpointed buffers to journal->j_max_transaction_buffers. But that is > guaranteed to be 0 at that point so we effectively stay with the default > shrinker batch size of 128. It has been like this since introduction of > jbd2 shrinkers so just drop the pointless initialization. > > Signed-off-by: Jan Kara <jack@xxxxxxx> Looks good to me. Reviewed-by: Zhang Yi <yi.zhang@xxxxxxxxxx> > --- > fs/jbd2/journal.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index ae5b544ed0cc..c356cc027ed7 100644 > --- a/fs/jbd2/journal.c > +++ b/fs/jbd2/journal.c > @@ -1641,7 +1641,6 @@ static journal_t *journal_init_common(struct block_device *bdev, > > journal->j_shrinker->scan_objects = jbd2_journal_shrink_scan; > journal->j_shrinker->count_objects = jbd2_journal_shrink_count; > - journal->j_shrinker->batch = journal->j_max_transaction_buffers; > journal->j_shrinker->private_data = journal; > > shrinker_register(journal->j_shrinker); >
