On Wed, 2024-06-19 at 08:58 +0100, Luis Henriques wrote: > On Wed 19 Jun 2024 12:30:38 AM +02, Ben Hutchings wrote; > > > On Tue, 2024-06-18 at 15:43 +0100, Luis Henriques (SUSE) wrote: > > > When fast-commit needs to track ranges, it has to handle inodes that have > > > inlined data in a different way because ext4_fc_write_inode_data(), in the > > > actual commit path, will attempt to map the required blocks for the range. > > > However, inodes that have inlined data will have it's data stored in > > > inode->i_block and, eventually, in the extended attribute space. > > > > > > Unfortunately, because fast commit doesn't currently support extended > > > attributes, the solution is to mark this commit as ineligible. > > > > > > Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039883 > > > Signed-off-by: Luis Henriques (SUSE) <luis.henriques@xxxxxxxxx> > > > > Reported-by: Hervé Werner <dud225@xxxxxxxxxxx> > > Tested-by: Ben Hutchings <benh@xxxxxxxxxx> > > > > Thanks a lot, Ben. > > > I think this should also have: > > > > Fixes: 9725958bb75c ("ext4: fast commit may miss tracking unwritten range during ftruncate") > > > > unless you think the problem is even older than that. > > If my understanding is correct (hopefully someone will confirm that!), I > think the problem goes further back. That commit just makes it more > likely to be visible, but handling of inlined data is incorrect since the > fast_commit merge. So, I guess that's better to simply add: > > Cc: stable@xxxxxxxxxxxxxxx That makes sense to me. Ben. -- Ben Hutchings For every complex problem there is a solution that is simple, neat, and wrong.
Attachment:
signature.asc
Description: This is a digitally signed message part
