On Sat, 16 Dec 2023 09:09:19 +0800, Ye Bin wrote: > Suppose we issue two FITRIM ioctls for ranges [0,15] and [16,31] with > mininum length of trimmed range set to 8 blocks. If we have say a range of > blocks 10-22 free, this range will not be trimmed because it straddles the > boundary of the two FITRIM ranges and neither part is big enough. This is a > bit surprising to some users that call FITRIM on smaller ranges of blocks > to limit impact on the system. Also XFS trims all free space extents that > overlap with the specified range so we are inconsistent among filesystems. > Let's change ext4_try_to_trim_range() to consider for trimming the whole > free space extent that straddles the end of specified range, not just the > part of it within the range. > > [...] Applied, thanks! [1/1] ext4: fix inconsistent between segment fstrim and full fstrim commit: 3d1aa1169c45aba9d589be1eb4b131f26f0a663c Best regards, -- Theodore Ts'o <tytso@xxxxxxx>