On Wed, Jan 03, 2024 at 06:28:14PM +0800, Kemeng Shi wrote:
> Remove unused parameter group in ext4_mb_choose_next_group_*().
Hey Kemeng,
Just a small thing, the parameter we are removing is "ngroups" rather
than "group" so maybe fix that in the commit message.
Other than that looks good, feel free to add
Reviewed-by: Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx>
>
> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
> ---
> fs/ext4/mballoc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 9f9b8dd06..765b62729 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -870,7 +870,7 @@ mb_update_avg_fragment_size(struct super_block *sb, struct ext4_group_info *grp)
> * cr level needs an update.
> */
> static void ext4_mb_choose_next_group_p2_aligned(struct ext4_allocation_context *ac,
> - enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)
> + enum criteria *new_cr, ext4_group_t *group)
> {
