Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
From: Max Kellermann <max.kellermann@xxxxxxxxx>
Date: Wed, 11 Oct 2023 14:18:45 +0200
Cc: Xiubo Li <xiubli@xxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Jan Kara <jack@xxxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, ceph-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, Christian Brauner <brauner@xxxxxxxxxx>, Yang Xu <xuyang2018.jy@xxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20231011120655.ndb7bfasptjym3wl@quack3>
References: <69dda7be-d7c8-401f-89f3-7a5ca5550e2f@oracle.com> <20231009144340.418904-1-max.kellermann@ionos.com> <20231010131125.3uyfkqbcetfcqsve@quack3> <CAKPOu+-nC2bQTZYL0XTzJL6Tx4Pi1gLfNWCjU2Qz1f_5CbJc1w@mail.gmail.com> <20231011100541.sfn3prgtmp7hk2oj@quack3> <CAKPOu+_xdFALt9sgdd5w66Ab6KTqiy8+Z0Yd3Ss4+92jh8nCwg@mail.gmail.com> <20231011120655.ndb7bfasptjym3wl@quack3>

On Wed, Oct 11, 2023 at 2:07 PM Jan Kara <jack@xxxxxxx> wrote:
> Indeed, *that* looks like a bug. Good spotting! I'd say posix_acl_create()
> defined in include/linux/posix_acl.h for the !CONFIG_FS_POSIX_ACL case
> should be stripping mode using umask. Care to send a patch for this?

You mean like the patch you're commenting on right now? ;-)

But without the other filesystems. I'll resend it with just the
posix_acl.h hunk.

Follow-Ups:
- Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
  - From: Jan Kara
- Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
  - From: Max Kellermann

References:
- Re: [PATCH] fs: apply umask if POSIX ACL support is disabled
  - From: Dave Kleikamp
- [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
  - From: Max Kellermann
- Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
  - From: Jan Kara
- Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
  - From: Max Kellermann
- Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
  - From: Jan Kara
- Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
  - From: Max Kellermann
- Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
  - From: Jan Kara

Prev by Date: Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
Next by Date: Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
Previous by thread: Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
Next by thread: Re: [PATCH v2] fs/{posix_acl,ext2,jfs,ceph}: apply umask if ACL support is disabled
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]