On Wed, Aug 30, 2023 at 03:25:03PM +0200, Jan Kara wrote: > On Thu 24-08-23 17:26:05, Zhang Yi wrote: > > From: Zhang Yi <yi.zhang@xxxxxxxxxx> > > > > __insert_pending() allocate memory in atomic context, so the allocation > > could fail, but we are not handling that failure now. It could lead > > ext4_es_remove_extent() to get wrong reserved clusters, and the global > > data blocks reservation count will be incorrect. The same to > > extents_status entry preallocation, preallocate pending entry out of the > > i_es_lock with __GFP_NOFAIL, make sure __insert_pending() and > > __revise_pending() always succeeds. > > > > Signed-off-by: Zhang Yi <yi.zhang@xxxxxxxxxx> > > Looks sensible. Feel free to add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> Thanks, I've applied the first two patches in this series, since these are bug fixes. The rest of the patch series requires more analysis and review. - Ted
