Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> writes: > Here are prepared work: > 1. Include mballoc-test.c to mballoc.c to be able test static function > in mballoc.c. > 2. Implement static stub to avoid read IO to disk. > 3. Construct fake super_block. Only partial members are set, more members > will be set when more functions are tested. > Then unit test for ext4_mb_new_blocks_simple is added. > > Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> > --- > fs/ext4/mballoc-test.c | 322 +++++++++++++++++++++++++++++++++++++++++ > fs/ext4/mballoc.c | 4 + > 2 files changed, 326 insertions(+) > create mode 100644 fs/ext4/mballoc-test.c Thanks for working on the review comments. The purpose of functions and structures are much clear now. Also the approach of including mballoc-test.c within #ifdef macros inside mballoc.c looks ok to me. Nice work in getting this ready! ext4_mb_new_blocks_simple() is a good first start (even though as of now it is a simple allocator for fast commit replay path) -ritesh
