Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> writes:
commit: extent ext4_mb_mark_context to support allocation under journal
^^^ extend
> Previously, ext4_mb_mark_context is only called under fast commit
> replay path, so there is no valid handle when we update block bitmap
> and group descriptor. This patch try to extent ext4_mb_mark_context
^^^^ extend
> to be used by code under journal. There are several improves:
^^^ improvement:
> 1. add "handle_t *handle" to struct ext4_mark_context to accept handle
> to journal block bitmap and group descriptor update inside
> ext4_mb_mark_context (the added journal caode is based on journal
^^^ code
(we can remove the next "journal code in")
> code in ext4_mb_mark_diskspace_used where ext4_mb_mark_context
> is going to be used.)
> 2. add EXT4_MB_BITMAP_MARKED_CHECK flag to control check if bits in block
> bitmap are already marked as allocation code under journal asserts that
> all bits to be changed are not marked before.
> 3. add "ext4_grpblk_t changed" to struct ext4_mark_context to notify number
> of bits in block bitmap has changed.
>
> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>
> Reviewed-by: Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx>
The patch functionally looks good to me. Please feel free to add -
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>
-ritesh
