Re: [PATCH v2] ext4: Add periodic superblock update check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu 24-08-23 00:53:44, Theodore Ts'o wrote:
> 
> On Thu, 10 Aug 2023 18:38:52 +0400, Vitaliy Kuznetsov wrote:
> > This patch introduces a mechanism to periodically check and update
> > the superblock within the ext4 file system. The main purpose of this
> > patch is to keep the disk superblock up to date. The update will be
> > performed if more than one hour has passed since the last update, and
> > if more than 16MB of data have been written to disk.
> > 
> > This check and update is performed within the ext4_journal_commit_callback
> > function, ensuring that the superblock is written while the disk is
> > active, rather than based on a timer that may trigger during disk idle
> > periods.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] ext4: Add periodic superblock update check
>       commit: 58d85f2e88c97c69c869cae6c6bdd1af32936146

Coverity is telling me that this commit is adding uninitialized variable
access to call_notify_err and it seems to be correct... call_notify_err
needs to be initialized to 0.

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux