On Fri, Aug 18, 2023 at 03:14:34PM +0800, Fengnan Chang wrote: > If we move the allocation and initialization the ext4_free_data > structure to ext4_try_to_trim_range, we need move > ext4_lock_group too, because we can't do alloc memory when > hold lock in ioctl context. > How about just remove ext4_trim_extent, and do all work in > ext4_try_to_trim_range? it will be easier to read. Yes, agreed. - Ted