On Mon, 26 Jun 2023 15:33:22 +0800, Zhang Yi wrote:
> We got a filesystem inconsistency issue below while running generic/475
> I/O failure pressure test with fast_commit feature enabled.
>
> Symlink /p3/d3/d1c/d6c/dd6/dce/l101 (inode #132605) is invalid.
>
> If fast_commit feature is enabled, a special fast_commit journal area is
> appended to the end of the normal journal area. The journal->j_last
> point to the first unused block behind the normal journal area instead
> of the whole log area, and the journal->j_fc_last point to the first
> unused block behind the fast_commit journal area. While doing journal
> recovery, do_one_pass(PASS_SCAN) should first scan the normal journal
> area and turn around to the first block once it meet journal->j_last,
> but the wrap() macro misuse the journal->j_fc_last, so the recovering
> could not read the next magic block (commit block perhaps) and would end
> early mistakenly and missing tN and every transaction after it in the
> following example. Finally, it could lead to filesystem inconsistency.
>
> [...]
Applied, thanks!
[1/1] jbd2: correct the end of the journal recovery scan range
commit: 3aab2c3d9ef0b30dd41e20c336377c43b4ca513e
Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>
