On Thu, Aug 17, 2023 at 10:48:51AM +0800, Kemeng Shi wrote: > > > errout: > > ret = ext4_journal_stop(handle); > > if (!err) > > ret = err; > > return ret; > > > I think you mean: > errout: > ret = ext4_journal_stop(handle); > if (*err*) > ret = err; > return ret; > And I will fix in this way if I don't get wrong. Yes, that's what I meant. Another way of putting it might be: ret = ext4_journal_stop(handle); return (err ? err : ret); - Ted