Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx> writes: > Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> writes: > >> We named criteria with CR_XXX, correct stale comment to criteria with >> raw number. >> >> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> >> --- >> fs/ext4/mballoc.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c >> index bfaab173a3f4..1e8ce0ece47a 100644 >> --- a/fs/ext4/mballoc.c >> +++ b/fs/ext4/mballoc.c >> @@ -2782,8 +2782,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) >> >> /* >> * ac->ac_2order is set only if the fe_len is a power of 2 >> - * if ac->ac_2order is set we also set criteria to 0 so that we >> - * try exact allocation using buddy. >> + * if ac->ac_2order is set we also set criteria to CR_POWER2_ALIGNED >> + * so that we try exact allocation using buddy. >> */ >> i = fls(ac->ac_g_ex.fe_len); >> ac->ac_2order = 0; >> @@ -2840,8 +2840,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) >> /* >> * Batch reads of the block allocation bitmaps >> * to get multiple READs in flight; limit >> - * prefetching at cr=0/1, otherwise mballoc can >> - * spend a lot of time loading imperfect groups >> + * prefetching at inexpensive CR, otherwise mballoc >> + * can spend a lot of time loading imperfect groups >> */ >> if ((prefetch_grp == group) && >> (ext4_mb_cr_expensive(cr) || > Is this function defined at any place ^^^ aah ok got it. Here [1] ...which you have also mentioned in your cover letetr. So your patch series currently is depenedent of above patch [1] [1]: https://lore.kernel.org/linux-ext4/20230630085927.140137-1-ojaswin@xxxxxxxxxxxxx/ Feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx> > > -ritesh
