On Mon, Jul 24, 2023 at 9:34 PM Su Hui <suhui@xxxxxxxxxxxx> wrote: > > clang's static analysis warning: fs/ext4/mballoc.c > line 4178, column 6, Branch condition evaluates to a garbage value. > > err is uninitialized and will be judged when 'len <= 0' or > it first enters the loop while the condition "!ext4_sb_block_valid()" > is true. Although this can't make problems now, it's better to > correct it. > > Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx> Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > --- > v2: > - modify commit message > > fs/ext4/mballoc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index 21b903fe546e..769000c970b0 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -4084,7 +4084,7 @@ void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block, > struct ext4_sb_info *sbi = EXT4_SB(sb); > ext4_group_t group; > ext4_grpblk_t blkoff; > - int i, err; > + int i, err = 0; > int already; > unsigned int clen, clen_changed, thisgrp_len; > > -- > 2.30.2 > -- Thanks, ~Nick Desaulniers
