On Fri, Jul 28, 2023 at 11:09:46AM -0400, Gabriel Krisman Bertazi wrote:
> Christian Brauner <brauner@xxxxxxxxxx> writes:
>
> > On Thu, Jul 27, 2023 at 01:28:39PM -0400, Gabriel Krisman Bertazi wrote:
>
> >
> > Wouldn't it make sense to get rid of all this indentation?
>
> I'm ok with making this change. I'll wait for more reviews and Eric
> before sending a new version with this done.
>
> Thanks!
>
Well, the issue is that with patch 4, all the 'return 1;' would need to change
to 'return fscrypt_d_revalidate(dentry, flags);'.
A helper function could be used, though, if you prefer:
static int generic_ci_d_revalidate(struct dentry *dentry,
const struct qstr *name, unsigned int flags)
{
if (!ci_d_revalidate(dentry, name, flags))
return 0;
return fscrypt_d_revalidate(dentry, flags);
}
- Eric
