Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> writes: > We named criteria with CR_XXX, correct stale comment to criteria with > raw number. > > Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> > --- > fs/ext4/mballoc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Looks good to me. Feel free to add: Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx> -ritesh > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index b04eceeab967..e30494f3d289 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -2778,8 +2778,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) > > /* > * ac->ac_2order is set only if the fe_len is a power of 2 > - * if ac->ac_2order is set we also set criteria to 0 so that we > - * try exact allocation using buddy. > + * if ac->ac_2order is set we also set criteria to CR_POWER2_ALIGNED > + * so that we try exact allocation using buddy. > */ > i = fls(ac->ac_g_ex.fe_len); > ac->ac_2order = 0; > @@ -2836,8 +2836,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) > /* > * Batch reads of the block allocation bitmaps > * to get multiple READs in flight; limit > - * prefetching at cr=0/1, otherwise mballoc can > - * spend a lot of time loading imperfect groups > + * prefetching at cr below CR_FAST, otherwise mballoc > + * can spend a lot of time loading imperfect groups > */ > if ((prefetch_grp == group) && > (cr >= CR_FAST || > -- > 2.30.0