We treat free_clusters_count in cluster unit while free_blocks_count is in block unit. Convert free_blocks_count to cluster unit to match the unit. Currently, verify_group_input is only called from ext4_ioctl_group_add which does not support bigalloc yet. The dismatch is easily ingored when we try to support bigalloc in ext4_ioctl_group_add (ext4_resize_fs already supports resize with bigalloc enabled). Just fix this in advance. Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> --- fs/ext4/resize.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 07828903b818..c532bb613043 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -154,8 +154,9 @@ static int verify_group_input(struct super_block *sb, overhead = ext4_group_overhead_blocks(sb, group); metaend = start + overhead; - input->free_clusters_count = free_blocks_count = - input->blocks_count - 2 - overhead - sbi->s_itb_per_group; + free_blocks_count = input->blocks_count - 2 - overhead - + sbi->s_itb_per_group; + input->free_clusters_count = EXT4_B2C(sbi, free_blocks_count); if (test_opt(sb, DEBUG)) printk(KERN_DEBUG "EXT4-fs: adding %s group %u: %u blocks " -- 2.30.0
