On Tue, Jun 20, 2023 at 10:43:39AM -0400, Sasha Levin wrote: > > Normally "Fixes" would be "Fixes:" and in the signed-off block. Plus, > > two consecutive sign-offs from tytso are probably wrong, too. > > I'm really not sure what you want us to do here, or in other places > where you've commented about issues with the upstream patch... Yeah, those were issues with the upstream commit. Sorry about that. I personally don't care about whether you "clean up" the commit before having it land in the LTS kernels or leave it as it as originally commited to upstream, but then again, I'm not the kind of person who asks whether there's a hyphen in "anal-retentive". (I'm given to understand it depends on whether the phrase is being used as an attributive or predicative adjective. :-) - Ted