On Sun 18-06-23 23:32:46, Bean Huo wrote:
> From: Bean Huo <beanhuo@xxxxxxxxxx>
>
> Originally inode is used to get blksize, after commit 45bce8f3e343
> ("fs/buffer.c: make block-size be per-page and protected by the page lock"),
> __block_commit_write no longer uses this parameter inode, this patch is to
> remove inode and clean up block_commit_write.
>
> Signed-off-by: Bean Huo <beanhuo@xxxxxxxxxx>
Nice! Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/buffer.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index a7fc561758b1..b88bb7ec38be 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -2116,8 +2116,7 @@ int __block_write_begin(struct page *page, loff_t pos, unsigned len,
> }
> EXPORT_SYMBOL(__block_write_begin);
>
> -static int __block_commit_write(struct inode *inode, struct page *page,
> - unsigned from, unsigned to)
> +int block_commit_write(struct page *page, unsigned int from, unsigned int to)
> {
> unsigned block_start, block_end;
> int partial = 0;
> @@ -2154,6 +2153,7 @@ static int __block_commit_write(struct inode *inode, struct page *page,
> SetPageUptodate(page);
> return 0;
> }
> +EXPORT_SYMBOL(block_commit_write);
>
> /*
> * block_write_begin takes care of the basic task of block allocation and
> @@ -2188,7 +2188,6 @@ int block_write_end(struct file *file, struct address_space *mapping,
> loff_t pos, unsigned len, unsigned copied,
> struct page *page, void *fsdata)
> {
> - struct inode *inode = mapping->host;
> unsigned start;
>
> start = pos & (PAGE_SIZE - 1);
> @@ -2214,7 +2213,7 @@ int block_write_end(struct file *file, struct address_space *mapping,
> flush_dcache_page(page);
>
> /* This could be a short (even 0-length) commit */
> - __block_commit_write(inode, page, start, start+copied);
> + block_commit_write(page, start, start+copied);
>
> return copied;
> }
> @@ -2535,14 +2534,6 @@ int cont_write_begin(struct file *file, struct address_space *mapping,
> }
> EXPORT_SYMBOL(cont_write_begin);
>
> -int block_commit_write(struct page *page, unsigned from, unsigned to)
> -{
> - struct inode *inode = page->mapping->host;
> - __block_commit_write(inode,page,from,to);
> - return 0;
> -}
> -EXPORT_SYMBOL(block_commit_write);
> -
> /*
> * block_page_mkwrite() is not allowed to change the file size as it gets
> * called from a page fault handler when a page is first dirtied. Hence we must
> --
> 2.34.1
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
