On Fri, 05 May 2023 21:24:29 +0800, Baokun Li wrote: > When ext4_iomap_overwrite_begin() calls ext4_iomap_begin() map blocks may > fail for some reason (e.g. memory allocation failure, bare disk write), and > later because "iomap->type ! = IOMAP_MAPPED" triggers WARN_ON(). When ext4 > iomap_begin() returns an error, it is normal that the type of iomap->type > may not match the expectation. Therefore, we only determine if iomap->type > is as expected when ext4_iomap_begin() is executed successfully. > > [...] Applied, thanks! [1/1] ext4: check iomap type only if ext4_iomap_begin() does not fail commit: 705c514635a4b6fd0ee321bcf1a9bd75c3629b71 Best regards, -- Theodore Ts'o <tytso@xxxxxxx>