Hi Eric! On Tue 09-05-23 14:20:15, Eric Whitney wrote: > I'm seeing two test regressions on 6.4-rc1 while running the adv test case > with kvm-xfstests. Both tests fail with 100% reliability in 100 trial runs, > and the failures appear to depend solely upon the fast commit mount option. > > The first is generic/065, where the relevant info from 065.full is: > > _check_generic_filesystem: filesystem on /dev/vdc is inconsistent > *** fsck.ext4 output *** > fsck from util-linux 2.36.1 > e2fsck 1.47.0 (5-Feb-2023) > Pass 1: Checking inodes, blocks, and sizes > Pass 2: Checking directory structure > Pass 3: Checking directory connectivity > Pass 4: Checking reference counts > Pass 5: Checking group summary information > Directories count wrong for group #16 (4294967293, counted=0). > > > The second is generic/535, where the test output is: > > QA output created by 535 > Silence is golden > +Before: 755 > +After : 777 > > Both test failures bisect to: e360c6ed7274 ("ext4: Drop special handling of > journalled data from ext4_sync_file()"). Reverting this patch eliminates the > test failures. So, I thought I'd bring these to your attention. Thanks for report! Yeah, when doing commit e360c6ed7274 I forgot about directories which can be also fsynced and which need special treatment. I have to think a bit what's the best way to fix this. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR