On 2023/4/28 11:16, Theodore Ts'o wrote:
There were two ways to return an error code; one was via setting the 'err' variable, and the second, if err was zero, was via the 'ret' variable. This was both confusing and fragile, and when code was factored out of __ext4_fill_super(), some of the error codes returned by the original code was replaced by -EINVAL, and in one case, the error code was placed by 0, triggering a kernel null pointer dereference. Clean this up by removing the 'ret' variable, leaving only one way to setfthe error code to be returned, and restore the errno codes that
setfthe -> set the? Otherwise looks good to me: Reviewed-by: Jason Yan <yanaijie@xxxxxxxxxx>
