On Wed, Apr 26, 2023 at 08:10:58PM +0100, Matthew Wilcox wrote: > > This feels like something smatch could catch. Adding Dan. > > Unfortunately, I don't know that we have any buildbots that run smatch, > and most developers don't, so it'll always be an after-the-fact patch > to fix it rather than "anybody using W=1" or "anybody using C=1" will > catch it before it gets anywhere near a maintainer. Well, if we can ask Mark Brown to run smatch on linux-next, we can catch most of these things quickly; in fact, this would have been *only* caught on linux-next, since in this case, we got caught out by a change in a function signature happening in one tree, and a new use of that function in another tree. Is this something that we could teach sparse to catch? - Ted
