On Thu, 16 Mar 2023 16:48:31 -0400, Tom Rix wrote: > cppcheck reports > fs/ext4/page-io.c:516:51: style: > Condition 'nr_to_submit' is always true [knownConditionTrueFalse] > if (fscrypt_inode_uses_fs_layer_crypto(inode) && nr_to_submit) { > ^ > This earlier check to bail, makes this check unncessary > /* Nothing to submit? Just unlock the page... */ > if (!nr_to_submit) > return 0; > > [...] Applied, thanks! [1/1] ext4: remove unneeded check of nr_to_submit commit: 8ae56b4e82ee29b5cc1fbea8b00a0a7e0758f3c2 Best regards, -- Theodore Ts'o <tytso@xxxxxxx>