On Thu, Apr 13, 2023 at 02:10:28PM +0530, Ritesh Harjani (IBM) wrote: > Add TRACE_IOCB_STRINGS macro which can be used in the trace point patch to > print different flag values with meaningful string output. > > Tested-by: Disha Goel <disgoel@xxxxxxxxxxxxx> > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx> > --- Fine, but fs.h is such a dumping ground already I hope we can split more stuff out of it going forward... > include/linux/fs.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 9ca3813f43e2..6903fc15987a 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -340,6 +340,20 @@ enum rw_hint { > /* can use bio alloc cache */ > #define IOCB_ALLOC_CACHE (1 << 21) > > +/* for use in trace events */ > +#define TRACE_IOCB_STRINGS \ > + { IOCB_HIPRI, "HIPRI" }, \ > + { IOCB_DSYNC, "DSYNC" }, \ > + { IOCB_SYNC, "SYNC" }, \ > + { IOCB_NOWAIT, "NOWAIT" }, \ > + { IOCB_APPEND, "APPEND" }, \ > + { IOCB_EVENTFD, "EVENTD"}, \ s/EVENTD/EVENTFD/