On Wed, Mar 29, 2023 at 05:49:37PM +0200, Jan Kara wrote: > /* > - * data=writeback,ordered: > * The caller's filemap_fdatawrite()/wait will sync the data. > * Metadata is in the journal, we wait for proper transaction to > * commit here. Nit: without the list, the two space indent looks a bit weird here. > if (!sbi->s_journal) > ret = ext4_fsync_nojournal(inode, datasync, &needs_barrier); > - else if (ext4_should_journal_data(inode)) > - ret = ext4_force_commit(inode->i_sb); > else > ret = ext4_fsync_journal(inode, datasync, &needs_barrier); Also if there is not journale the above comment doesn't make much sense. But I'm really not sure the comment adds any value to start with, so maybe just drop it entirely?
