On Tue, Mar 14, 2023 at 06:26:46PM -0400, Theodore Ts'o wrote: > On Tue, Mar 07, 2023 at 12:15:13AM +0530, Ritesh Harjani wrote: > > "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> writes: > > > > > Prepare for multi-page folios and save some instructions by converting > > > to the folio API. > > > > Mostly a straight forward change. The changes looks good to me. > > Please feel free to add - > > > > Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx> > > > > In later few patches I see ext4_readpage converted to ext4_read_folio(). > > I think the reason why we have not changed ext4_writepage() to > > ext4_write_folio() is because we anyway would like to get rid of > > ->writepage ops eventually in future, so no point. > > I think there is even patch series from Jan which tries to kill > > ext4_writepage() completely. > > Indeed, Jan's patch series[1] is about to land in the ext4 tree, and > that's going to remove ext4_writepages. The main reason why this > hadn't landed yet was due to some conflicts with some other folio > changes, so you should be able to drop this patch when you rebase this > patch series. Correct; in the rebase, I ended up just dropping this patch.
