On Fri 17-03-23 22:07:43, Theodore Ts'o wrote: > On Wed, Mar 08, 2023 at 11:42:34AM +0100, Jan Kara wrote: > > > That analysis looks correct. FYI, I think this is the same as the syzbot report > > > "[ext4?] WARNING: bad unlock balance in ext4_rename2" > > > (https://lore.kernel.org/linux-ext4/000000000000435c6905f639ae8e@xxxxxxxxxx). > > > > Good spotting! This should be fixed (along with the lock ordering problem) > > by 3c92792da8506 ("ext4: Fix deadlock during directory rename") Ted has > > just merged couple hours ago. > > Unfortunately, the Syzkaller report is still triggering after the > merge and commit 3c92792da8506. The double unlock is still there, and > so the following fix is still needed (which I will be sending to Linus). Bah, right. Thanks for fixing this! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
