On Wed 22-02-23 04:30:25, Kemeng Shi wrote:
> Remove unused group parameter in ext4_inode_bitmap_csum_set.
>
> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/ext4/bitmap.c | 2 +-
> fs/ext4/ext4.h | 2 +-
> fs/ext4/ialloc.c | 6 +++---
> fs/ext4/resize.c | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ext4/bitmap.c b/fs/ext4/bitmap.c
> index 3bb28fad624f..0186b894f5b3 100644
> --- a/fs/ext4/bitmap.c
> +++ b/fs/ext4/bitmap.c
> @@ -38,7 +38,7 @@ int ext4_inode_bitmap_csum_verify(struct super_block *sb,
> return provided == calculated;
> }
>
> -void ext4_inode_bitmap_csum_set(struct super_block *sb, ext4_group_t group,
> +void ext4_inode_bitmap_csum_set(struct super_block *sb,
> struct ext4_group_desc *gdp,
> struct buffer_head *bh, int sz)
> {
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index db2476daebd2..aa6948d12ede 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2676,7 +2676,7 @@ struct mmpd_data {
>
> /* bitmap.c */
> extern unsigned int ext4_count_free(char *bitmap, unsigned numchars);
> -void ext4_inode_bitmap_csum_set(struct super_block *sb, ext4_group_t group,
> +void ext4_inode_bitmap_csum_set(struct super_block *sb,
> struct ext4_group_desc *gdp,
> struct buffer_head *bh, int sz);
> int ext4_inode_bitmap_csum_verify(struct super_block *sb,
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index 7e388340f588..b86756c57c0b 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -327,7 +327,7 @@ void ext4_free_inode(handle_t *handle, struct inode *inode)
> if (percpu_counter_initialized(&sbi->s_dirs_counter))
> percpu_counter_dec(&sbi->s_dirs_counter);
> }
> - ext4_inode_bitmap_csum_set(sb, block_group, gdp, bitmap_bh,
> + ext4_inode_bitmap_csum_set(sb, gdp, bitmap_bh,
> EXT4_INODES_PER_GROUP(sb) / 8);
> ext4_group_desc_csum_set(sb, block_group, gdp);
> ext4_unlock_group(sb, block_group);
> @@ -852,7 +852,7 @@ int ext4_mark_inode_used(struct super_block *sb, int ino)
>
> ext4_free_inodes_set(sb, gdp, ext4_free_inodes_count(sb, gdp) - 1);
> if (ext4_has_group_desc_csum(sb)) {
> - ext4_inode_bitmap_csum_set(sb, group, gdp, inode_bitmap_bh,
> + ext4_inode_bitmap_csum_set(sb, gdp, inode_bitmap_bh,
> EXT4_INODES_PER_GROUP(sb) / 8);
> ext4_group_desc_csum_set(sb, group, gdp);
> }
> @@ -1222,7 +1222,7 @@ struct inode *__ext4_new_inode(struct user_namespace *mnt_userns,
> }
> }
> if (ext4_has_group_desc_csum(sb)) {
> - ext4_inode_bitmap_csum_set(sb, group, gdp, inode_bitmap_bh,
> + ext4_inode_bitmap_csum_set(sb, gdp, inode_bitmap_bh,
> EXT4_INODES_PER_GROUP(sb) / 8);
> ext4_group_desc_csum_set(sb, group, gdp);
> }
> diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
> index 6b91443d6bf3..607a1af00665 100644
> --- a/fs/ext4/resize.c
> +++ b/fs/ext4/resize.c
> @@ -1318,7 +1318,7 @@ static int ext4_set_bitmap_checksums(struct super_block *sb,
> bh = ext4_get_bitmap(sb, group_data->inode_bitmap);
> if (!bh)
> return -EIO;
> - ext4_inode_bitmap_csum_set(sb, group, gdp, bh,
> + ext4_inode_bitmap_csum_set(sb, gdp, bh,
> EXT4_INODES_PER_GROUP(sb) / 8);
> brelse(bh);
>
> --
> 2.30.0
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
