Hi Ted! On Tue 28-02-23 00:13:12, Theodore Ts'o wrote: > This is Jan's data=journal cleanup patch series, previously submitted > here[1] rebased on top of Linus's patches to address merge conflicts > with mm-stable, per this discussion[2]. > > [1] https://lore.kernel.org/r/20230111152736.9608-1-jack@xxxxxxx > [2] https://lore.kernel.org/r/Y/k4Jvph15ugcY54@xxxxxxx > > While retesting this patch series, I've noticed a potential regression > which doesn't trigger before applying the last patch in this series > (Convert data=journal writeback to use ext4_writepages), but which > triggers a WARNING in generic/390 about half the time. I've gone back > and retested, and this was happening before the rebase. > > Jan, could you take a look and (1) let me know what you think about my > patch conflict resolutions and (2) what you think about this warning > which is occasionally triggered by generic/390? Many thanks! I went through the patches and they look good to me. I have a side note that obviously the code isn't quite going to work for folios larger than 1 page but for 1 page folios we should be fine. Regarding the warning somehow there are dirty pages left after the procedures freeze_super() goes through to flush all dirty data. That is not too surprising since in data=journal mode pages get (as a surprise to freezing code) dirtied when transaction commits. I thought we have this covered by jbd2_journal_flush() call in ext4_freeze() but maybe there are some stranded PageDirty bits left? It needs more debugging... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
